Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asmjs takes 17s to calculate txBuilder.min_fee() #328

Closed
honungsburk opened this issue Jan 14, 2022 · 3 comments
Closed

asmjs takes 17s to calculate txBuilder.min_fee() #328

honungsburk opened this issue Jan 14, 2022 · 3 comments

Comments

@honungsburk
Copy link

honungsburk commented Jan 14, 2022

I've experienced performance issues using the asmjs of the library. Profiling my own code I noticed that txBuilder.min_fee() takes roughly ~17s to execute (this is using v9.1.4). I saw that some work has already been put into trying to resolve this issue, namely #213 and #214. Reading #323 I believe these changes to already been merged but perhaps the problem persists? Are there any other improvements that are yet to be merged?

@vsubhuman
Copy link
Contributor

Best improvement for that is switching to the WASM version if possible https://www.npmjs.com/package/@emurgo/cardano-serialization-lib-browser

@honungsburk
Copy link
Author

Yeah, that sounds like a good solution

@honungsburk
Copy link
Author

Oh, I'm sorry. I thought I was using v9.1.4 but was actually using v9.1.2. Updating to v9.1.4 and running my profiling speed it up significantly! Now there is no issue. Sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants