Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action fails on Windows #41

Open
goerwin opened this issue Apr 20, 2021 · 3 comments
Open

Action fails on Windows #41

goerwin opened this issue Apr 20, 2021 · 3 comments
Assignees
Labels
good first issue Good for newcomers status: pinned Should not be labeled as stale type: bug Verified problems that need to be worked on

Comments

@goerwin
Copy link

goerwin commented Apr 20, 2021

Describe the bug
Using EndBug/version-check@v2 throws a 404 when the repo is private

To Reproduce
Using this workflow:

name: release

on:
  push:
    branches: [master]

jobs:
  release:
    runs-on: ${{ matrix.os }}

    strategy:
      matrix:
        os: [windows-latest]

    steps:
      - name: Check out Git repository
        uses: actions/checkout@v2

      - name: Install Node.js, NPM and Yarn
        uses: actions/setup-node@v2
        with:
          node-version: 14

      - id: check
        name: Verify package.json version change
        uses: EndBug/version-check@v2
        with:
          token: ${{ secrets.GITHUB_TOKEN }}

      - name: push new tag
        if: steps.check.outputs.changed == 'true'
        run: 'git tag v${{ steps.check.outputs.version }}'

result logs
captura_2021-04-19_21_01_08

@goerwin goerwin added the status: pending More info is needed before deciding what to do label Apr 20, 2021
@EndBug EndBug added good first issue Good for newcomers status: pinned Should not be labeled as stale type: bug Verified problems that need to be worked on and removed status: pending More info is needed before deciding what to do labels Apr 21, 2021
@EndBug EndBug self-assigned this Apr 21, 2021
@EndBug
Copy link
Owner

EndBug commented Apr 21, 2021

I've been able to reproduce this, but the issue is not about private repos, but about jobs that run on windows (windows-latest, windows-2019).
I'm working on a rewrite and I'll try to look into this as well. For the time being, I can only suggest you to use another OS for your builds if you can.

@EndBug EndBug changed the title Version 2 fails with private repo [Bug] Action fails on Windows Apr 21, 2021
@halvardssm
Copy link

Hi @EndBug ! Do you have any idea what could be the issue for it to be failing on windows? I am happy to contribute with a fix!

@EndBug
Copy link
Owner

EndBug commented Sep 23, 2021

@halvardssm Honestly I have no clue ahahha. I haven't got around the rewrite...
If you find a fix feel free to open a PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers status: pinned Should not be labeled as stale type: bug Verified problems that need to be worked on
Projects
None yet
Development

No branches or pull requests

3 participants