Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android 11 magisk module path changed #2

Open
slabua opened this issue Sep 12, 2020 · 4 comments
Open

Android 11 magisk module path changed #2

slabua opened this issue Sep 12, 2020 · 4 comments

Comments

@slabua
Copy link

slabua commented Sep 12, 2020

The following line should be update as follows:

modPath="/sbin/.magisk/modules/energizedprotection/system/bin"

modPath="/data/adb/modules/energizedprotection/system/bin"

@AvinashReddy3108
Copy link

This affects only those devices with the Android 11 installed right?
If yes, we should additionally check for Android version before changing the modPath variable.

@slabua
Copy link
Author

slabua commented Sep 12, 2020

I think sbin/.magisk is/was a reference to the actual real path which was /data/adb/modules also in previous versions. So linking to the original path should not break previous versions.

Better way possibly, let the script itself find out its own location.

@LoganDark
Copy link

Magisk has been in /data/adb for a while now

@AvinashReddy3108
Copy link

AvinashReddy3108 commented Dec 1, 2020

I think sbin/.magisk is/was a reference to the actual real path which was /data/adb/modules also in previous versions. So linking to the original path should not break previous versions.

Better way possibly, let the script itself find out its own location.

This snippet does help us find the location, feel free to check it out.

5bf49be#diff-146a351e388ce71d7689e634b5d8c2c5b990117edf8317b4febf68dd0d99c405R10-R18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants