Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug when using the GUI on low resolution #12

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

Zetison
Copy link
Collaborator

@Zetison Zetison commented Sep 13, 2024

Several Makie items disappeared on a low-resolution window, which becomes a problem on small monitors (like a laptop). For this reason, buttons and menus have been reordered to enable GUI on low resolution (i.e. [1280, 729]). The text area has also been divided into two areas (the new one for permanently showing the result summary). Improve code quality.

…, 729]). Divided the text area into two areas (the new one for permanently showing result summary). Improve code quality.
@Zetison Zetison added the bug Something isn't working label Sep 13, 2024
@Zetison Zetison requested a review from magnuask September 13, 2024 06:50
@Zetison Zetison self-assigned this Sep 13, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 80.35714% with 11 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/utils_gen/utils.jl 31.25% 11 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files with missing lines Coverage Δ
src/setup_GUI.jl 100.00% <100.00%> (ø)
src/utils_GUI/GUI_utils.jl 94.36% <100.00%> (ø)
src/utils_GUI/event_functions.jl 99.00% <100.00%> (ø)
src/utils_GUI/info_axis_utils.jl 96.66% <100.00%> (ø)
src/utils_GUI/results_axis_utils.jl 96.36% <ø> (ø)
src/utils_GUI/topo_axis_utils.jl 94.20% <ø> (ø)
src/utils_gen/structures_utils.jl 95.12% <100.00%> (ø)
src/utils_gen/topo_utils.jl 98.95% <100.00%> (ø)
src/utils_gen/utils.jl 86.81% <31.25%> (ø)

@Zetison Zetison merged commit 3a19ebf into main Sep 13, 2024
4 checks passed
@Zetison Zetison deleted the bugfix/EMGUI_on_low_resolution branch September 13, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants