Skip to content
This repository has been archived by the owner on Feb 27, 2024. It is now read-only.

<br> in tables breaks the plugin #3

Open
daxcore opened this issue Feb 10, 2024 · 4 comments
Open

<br> in tables breaks the plugin #3

daxcore opened this issue Feb 10, 2024 · 4 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@daxcore
Copy link

daxcore commented Feb 10, 2024

https://github.com/ObsidianPublisher/mkdocs-custom-tags-attributes/blob/73c64c9417680ecb166598bd717d09f360f05a77/custom_attributes/plugin.py#L124

Obsidian uses just <br> by default without end tag for line breaks in tables, which matches the markdown rules.

Also </br> doesn't work.

@Mara-Li
Copy link
Member

Mara-Li commented Feb 10, 2024

Could you please provide a minimum reproduction file so i can try while fixing ?
Thanks!

@daxcore
Copy link
Author

daxcore commented Feb 10, 2024

ofc, like this:

| a | b |
| ---- | ---- |
| this #tag works | ... |
| but not this #tag | multi<br>line |
| </hack>  |  |
| but this #tag again because of hack |  |
| and a #tag on line with br also fails | multi<br>line |

@Mara-Li
Copy link
Member

Mara-Li commented Feb 11, 2024

Okay I understand better the problem, as it parse in the same line, it will think that it is in code blocks because of the

I really don't know how I can :

  • Allow #tags
  • prevent <#tags>
  • preventing any tags in code blocks in general (like # are used in comments in many langage)

I have many difficulties with python to do that to be honest…

@Mara-Li Mara-Li added the help wanted Extra attention is needed label Feb 11, 2024
@Mara-Li Mara-Li self-assigned this Feb 11, 2024
@daxcore
Copy link
Author

daxcore commented Feb 11, 2024

okay so maybe this plugin is not that, i'm searching for.
the functionality to just handle the obsidian tags in material for mkdocs is much less than this plugin here.
so i started with a different plugin as base: ndy2/mkdocs-obsidian-support-plugin#6
like u can see, there are just some productive lines.
however, thanks for the idea, resulted by this plugin here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants