-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding envoPlastics subset #1092
Conversation
Thanks @raissameyer - did you build the ontology locally to see if the Makefile generates the expected subsets? |
No sorry, I have yet to do that. @pbuttigieg Would you mind linking me to some guidance on building the ontology locally? |
…erm plastic pollution to then test if the subset works
We'll set up a call for this - but we should also take this opportunity to generate some documentation for the wiki |
Thanks @pbuttigieg. I've now built ENVO locally, and the Makefile generated the expected subsets. including Following up on issue #1085 - it seems that it is not required to update SLIM list in Makefile, as the subsets were created despite them not being in that list. We should update the wiki page accordingly.
I've noted down my steps as I went along, and would be happy to clean that up for a wiki page (either to be added to the wiki on Making a new subset, or in a new one). |
Many thanks for the revision and testing @raissameyer - merging! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved post hoc - @raissameyer this is a good PR to link to the documentation to show what code needs to be changed
Many thanks for the merge @pbuttigieg - I've updated ENVO's wiki page accordingly. |
For our projects the UN Environment Working Group for SDG 14, I've created a subset for Plastics
envoPlastics
following the guidance on the corresponding wiki page, and @pbuttigieg's guidance here.Please let me know if revisions are necessary.