Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CustomDateFormat Plugin: Hours always undefined #2741

Closed
3 tasks done
blankse opened this issue Dec 15, 2022 · 2 comments
Closed
3 tasks done

CustomDateFormat Plugin: Hours always undefined #2741

blankse opened this issue Dec 15, 2022 · 2 comments

Comments

@blankse
Copy link
Contributor

blankse commented Dec 15, 2022

Prerequisites

Describe the issue

After update from 6.2.7 to 6.2.8 the hours are always undefined.

StackBlitz fork

https://stackblitz.com/edit/tempus-dominus-v6-simple-setup-import-vsrvmt?file=index.js

What operating system(s) are you seeing the problem on?

Windows

What browser(s) are you seeing the problem on?

Chrome

What version of are you using? You can find this information from the sample StackBlitz.

6.2.8

What your browser's locale? You can find this information from the sample StackBlitz.

de-DE

@blankse
Copy link
Contributor Author

blankse commented Dec 15, 2022

@Eonasdan I think it was a regression from 3de5da3
The hoursFormatted and twelveHoursFormatted methods of the DateTime was removed but is used in the CustomDateFormat plugin.

@blankse
Copy link
Contributor Author

blankse commented Dec 15, 2022

I created a PR with a fix #2742

@Eonasdan Eonasdan added Type: Bug v6 Area: Plugins and removed State: Triage Tickets that need to be triaged. labels Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants