Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DRY repetition penalty #635

Closed
p-e-w opened this issue Jul 27, 2024 · 1 comment · Fixed by #637
Closed

Add DRY repetition penalty #635

p-e-w opened this issue Jul 27, 2024 · 1 comment · Fixed by #637
Labels
new feature New feature or request

Comments

@p-e-w
Copy link
Contributor

p-e-w commented Jul 27, 2024

DRY is a modern repetition penalty that is superior to the standard frequency and presence penalties at preventing repetition, while having virtually none of their negative effects on language quality.

Original implementation with detailed explanation: oobabooga/text-generation-webui#5677

C++ implementation in llama.cpp (pending merge): ggml-org/llama.cpp#6839

Independent C++ implementation in Kobold (merged): LostRuins/koboldcpp#982
@p-e-w p-e-w added the new feature New feature or request label Jul 27, 2024
@EricLBuehler EricLBuehler mentioned this issue Jul 27, 2024
Merged
@EricLBuehler
Copy link
Owner

@p-e-w I just added a PR for this. If you could give it a review that would be amazing.

@EricLBuehler EricLBuehler linked a pull request Aug 27, 2024 that will close this issue
Implement DRY penalty #637
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
new feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement DRY penalty EricLBuehler/mistral.rs
2 participants
@p-e-w @EricLBuehler