Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review status change: user unable to edit review comment without switching to different and switching back #1367

Closed
whisperity opened this issue Feb 14, 2018 · 1 comment · Fixed by #4082
Assignees
Labels
bug 🐛 GUI 🎨 usability 👍 Usability-related features web 🌍 Related to the web app

Comments

@whisperity
Copy link
Contributor

whisperity commented Feb 14, 2018

If a user sets the review status to something and then wants to edit it, the only way to do so is by switching to a different review status and committing a dummy or empty message, then switching back to the intended review status and typing in (or pasting...) the edited message.

If #746 ever happens, this will create a bloat for the report's history.

Edit: This part above is fixed since, identity changes are not creating additional "system comment" records.

Suggestion: When the user opens the review status drop-down and selects the same value as the current one, the comment window should open with the current comment pre-loaded. The user types in the new text (use case is adding new information why something is false positive or intentional) and commits it. (This will only result in one action changing the database and one "system comment" for #746 later.) If the user doesn't want to edit, the ESC or close button will cancel the action.

@csordasmarton csordasmarton self-assigned this Feb 15, 2018
@whisperity whisperity added the web 🌍 Related to the web app label Nov 13, 2020
@whisperity
Copy link
Contributor Author

This was partially fixed, I believe. The review status change is only committed if the message differs.

image

However, the existing status still needs to be loaded from either the 🗯️ icon, or from the system comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 GUI 🎨 usability 👍 Usability-related features web 🌍 Related to the web app
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants