Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show both review and detection status icons (or use different grouping) in the "Reports in the current file" view #3037

Closed
whisperity opened this issue Nov 20, 2020 · 0 comments · Fixed by #3053
Labels

Comments

@whisperity
Copy link
Contributor

Is your feature request related to a problem? Please describe.
I am using CodeChecker to categorise a considerable (upper hundreds) amount of bug reports. Normally, I filter for the bugs that are not yet overviewed, and then I open the first one. Then, I like to go over all the bugs in the current file shown in the left-hand view. Some of these bugs, however, are already reviewed, so opening them is a useless act (and also the fact of having been already reviewed is not immediately apparent, see #3026). Some or all of the reports in a file could be reviewed already due to having been reviewed in another run earlier.

It is worth noting that the "reports in the current file" view does not respect some of the filters set when opening the report view (e.g. if I'm listing only Unreviewed reports and click on a file, I get to see Confirmed reports too), but also seems to at least respect the run filter (i.e. even though there are "more" reports to the file in another run, I'm not seeing those).

Describe the solution you would like
Next to the "detection status" icon, the "review status" for the report should also be shown. (In my current work, the detection status feature does not make sense, as the bugs being categorised will never really be fixed and the project will never be reanalysed, so everything is New in terms of detection status).

There's plenty of space to show the icon, because right now this list shows no indication to me which is the "next" unreviewed bug in the file, as this is just a list sorted by line number.
image

Please excuse my horrible paint job:

image

Describe alternatives you have considered
Grouping the bugs in the tree first by review status, and then by severity. This could be even better, coupled with a logic that opens the trees for the "outstanding" stati automatically when a file is opened, while "hiding" all the review-handled reports in closed subtrees. In case I wanted to go back to previously reviewed bugs, I could just open those subtrees.

+-- Unreviewed
|--+-- High
|  |--- Bug 1
|  |--- Bug 2
+-- Confirmed
|--+-- Medium
|  |--- Bug 8
--- False positive    // closed.

The first option (just showing two icons instead of one) seems easier to implement, as all the data needed should be available already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants