CodeChecker server connects to untrusted LDAPS server for authentication

[jimis]

No description provided.

[csordasmarton]

@jimis Could you please describe this problem a little bit more? For example how can we reproduce the problem?

[jimis]

@csordasmarton to verify you just set an untrusted LDAP server to connect to via "ldaps" (EDIT: for example with a self-signed certificate for the server). Authentication will just work, while it shouldn't.

With #3083 you will get an error instead like this:

[DEBUG] - cc_ldap.py:340 auth_user() - Creating SERVICE connection...
[DEBUG] - cc_ldap.py:248 __init__() - Binding to LDAP server with user: USERNAME
[DEBUG] - cc_ldap.py:257 __init__() - Binding with credential: USERNAME
[ERROR] - cc_ldap.py:137 ldap_error_handler() - LDAP Error: {'desc': "Can't contact LDAP server", 'info': '(unknown error code)'}
[DEBUG] - cc_ldap.py:278 __init__() - Server bind failed.
[ERROR] - cc_ldap.py:346 auth_user() - Please check your LDAP server authentication credentials.
[ERROR] - cc_ldap.py:348 auth_user() - Configured username: USERNAME