Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web] Cannot set review status of bug B to X after setting bug A to X in the same file **without** going back to the Reports list #3830

Closed
whisperity opened this issue Jan 31, 2023 · 5 comments
Labels
bug 🐛 GUI 🎨 usability 👍 Usability-related features web 🌍 Related to the web app

Comments

@whisperity
Copy link
Contributor

whisperity commented Jan 31, 2023

Describe the bug
The review status drop-down does not allow selecting the same option when an option is already selected, even between separate reports. Related to #3026.

CodeChecker version
6.21.0 - 6.22.2

To Reproduce
Steps to reproduce the behaviour:

  1. Have a run with two bugs in the same file, both "Unreviewed".
  2. Open bug A from the "Reports" list.
  3. Change the status to "Confirmed bug".
  4. Switch to bug B within the file (the left-hand side tree view), without going back to the full report list.
  5. Review status stays "Confirmed bug". I cannot set bug B to the same "Confirmed bug" without first setting it to "Unreviewed" (with an empty comment) and then setting it to "Confirmed bug" with a meaningful comment.
  6. Alternatively, I need to go back to the run-level "Reports" list and remember which file I was in.

Expected behaviour
Whether the change of the review status is allowed should be checked every time the UI option is clicked? This sounds like some ViewModel caching issue.

@whisperity whisperity added bug 🐛 GUI 🎨 usability 👍 Usability-related features web 🌍 Related to the web app labels Jan 31, 2023
@vodorok
Copy link
Contributor

vodorok commented Feb 22, 2023

Are you clicking on the line which opens the tree element? (blue bug icon lines) Clicking on these does not change the report selection.
Clicking on the note tag row does (or any other bug path element referencing child).
image

I agree, that changing the behaviour of the selection so that clicking the top-level bug items, (the rows starting with bug icons) should change the selected report.

@whisperity
Copy link
Contributor Author

I think it's with the bug message (what's highlighted in your picture). But the problem isn't that clicking the Lxx - checker-name line doesn't swap the report, it's that clicking on the message and changing the report still doesn't update the review status dropdown.

@whisperity whisperity added this to the release 6.23.0 milestone Oct 19, 2023
@whisperity
Copy link
Contributor Author

@cservakt Can you check if #4082 also fixed this issue? It falls in line with the various other similar issues so I'd guess it should also be fixed...

@cservakt
Copy link
Collaborator

#4082 almost completely resolved. You can set the review status of the report, and the review status dropdown menu is also updated when changing the report on the sidebar.
The only remaining problem is that the sidebar isn't updated when the review status changes. I've already started an another PR that will hopefully fix it.

@whisperity
Copy link
Contributor Author

Okay I checked in practice and v6.23 solved this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 GUI 🎨 usability 👍 Usability-related features web 🌍 Related to the web app
Projects
None yet
Development

No branches or pull requests

3 participants