Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REPO] - Make hotshot_example a feature flag #2179

Open
shenkeyao opened this issue Dec 6, 2023 · 0 comments
Open

[REPO] - Make hotshot_example a feature flag #2179

shenkeyao opened this issue Dec 6, 2023 · 0 comments
Assignees
Labels

Comments

@shenkeyao
Copy link
Member

What is this task and why do we need to work on it?

Make hotshot_example a feature flag rather than a RUSTFLAG. Then we could create feature flags in downstream crates that enable this, like

[features]
testing = ["hotshot-testing/hotshot-example"]

What work will need to be done to complete this task?

No response

Are there any other details to include?

No response

What are the acceptance criteria to close this issue?

Code builds and is useable in the downstream crate.

Branch work will be merged to (if not the default branch)

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants