This repository has been archived by the owner on Mar 9, 2021. It is now read-only.
circles are still not being closed with Circle. New failing test illustrates it. #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ows that the Circle is still not producing closed circles The previous test syntax was not working as intended because it was not taking into account the nesting of the coordinates structure. If you simply dump out the entire coordinate list returned, you can see that the last point is not the same as the first point, as it should be. This test update correctly takes the nesting into account and tests both the latitude and longitude.
|
The fact that circles are confirmed to be calculated incorrectly seems fairly important. Any progress on this? Is help needed with the patch? |
|
@markstos sorry this has slipped through the cracks. I can probably patch this this before the week is out. Going to merge this though, thanks for the failing test. |
patrickarlt
added a commit
that referenced
this pull request
Feb 20, 2014
circles are still not being closed with Circle. New failing test illustrates it.
|
@markstos Fixed in 1.0.3 |
|
Thanks! I'll give it a test drive. On 2/24/14, Patrick Arlt notifications@github.com wrote:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous test syntax was not working as intended because it was not
taking into account the nesting of the coordinates structure.
If you simply dump out the entire coordinate list returned, you can see
that the last point is not the same as the first point, as it should be.
This test update correctly takes the nesting into account and tests
both the latitude and longitude.