Merge pull request #153 from Esri/bug/pass-through-false

fix(request): ensure request is passed through as a request parameter
Esri · Mar 5, 2018 · 43936f7 · 43936f7
2 parents 1173a88 + 77ad553
commit 43936f7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/packages/arcgis-rest-request/src/utils/process-params.ts b/packages/arcgis-rest-request/src/utils/process-params.ts
@@ -47,7 +47,7 @@ export function processParams(params: any): any {
 
   Object.keys(params).forEach(key => {
     const param = params[key];
-    if (!param && param !== 0) {
+    if (!param && param !== 0 && typeof param !== "boolean") {
       return;
     }
     const type = param.constructor.name;

diff --git a/packages/arcgis-rest-request/test/utils/process-params.test.ts b/packages/arcgis-rest-request/test/utils/process-params.test.ts
@@ -79,11 +79,13 @@ describe("processParams", () => {
 
   it("should stringify booleans", () => {
     const params = {
-      foo: true
+      foo: true,
+      bar: false
     };
 
     const expected = {
-      foo: "true"
+      foo: "true",
+      bar: "false"
     };
 
     expect(processParams(params)).toEqual(expected);