fix(check-for-errors): throw an error for a response with a \`failure…

…\` status

AFFECTS PACKAGES:
@esri/arcgis-rest-request

packages/arcgis-rest-request/src/utils/check-for-errors.ts

@@ -38,15 +38,15 @@ export function checkForErrors(
   }
 
   // error from a status check
-  if (response.status === "failed") {
+  if (response.status === "failed" || response.status === "failure") {
     let message: string;
     let code: string = "UNKNOWN_ERROR_CODE";
 
     try {
       message = JSON.parse(response.statusMessage).message;
       code = JSON.parse(response.statusMessage).code;
     } catch (e) {
-      message = response.statusMessage;
+      message = response.statusMessage || response.message;
     }
 
     throw new ArcGISRequestError(message, code, response, url, options);

packages/arcgis-rest-request/test/mocks/errors.ts

@@ -47,6 +47,12 @@ export const BillingError: any = {
   details: null as any
 };
 
+export const BillingErrorWithCode200: any = {
+  code: 200,
+  message: null,
+  status: "failure"
+};
+
 export const TaskErrorWithJSON: any = {
   status: "failed",
   statusMessage:

packages/arcgis-rest-request/test/utils/check-for-errors.test.ts

@@ -13,7 +13,8 @@ import {
   ArcGISOnlineErrorNoMessageCode,
   ArcGISOnlineErrorNoCode,
   ArcGISServerTokenRequired,
-  ArcGISOnlineAuthError
+  ArcGISOnlineAuthError,
+  BillingErrorWithCode200
 } from "./../mocks/errors";
 
 describe("checkForErrors", () => {
@@ -60,6 +61,12 @@ describe("checkForErrors", () => {
     }).toThrowError(ArcGISRequestError, "500: Error getting subscription info");
   });
 
+  it("should throw an ArcGISRequestError for an error from the ArcGIS Online Billing Backend with a failure status", () => {
+    expect(() => {
+      checkForErrors(BillingErrorWithCode200);
+    }).toThrowError(ArcGISRequestError, null);
+  });
+
   it("should throw an ArcGISRequestError for an error when checking long running tasks in ArcGIS REST API", () => {
     expect(() => {
       checkForErrors(TaskErrorWithJSON);