Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

custom geocoding services don't always require authentication. #216

Closed
jgravois opened this issue Jun 10, 2018 · 0 comments
Closed

custom geocoding services don't always require authentication. #216

jgravois opened this issue Jun 10, 2018 · 0 comments
Assignees
@jgravois

Comments

@jgravois
Copy link
Contributor

jgravois commented Jun 10, 2018 •
edited
Loading

case in point: https://cityofdetroit.github.io/geocode/

two suggestions:

  1. only throw an error when auth is missing and the url === our world geocoding service.
  2. add a few more code snippets (and links to the appropriate API reference pages) to the package README.
@jgravois jgravois self-assigned this Jun 10, 2018
jgravois added a commit that referenced this issue Jun 12, 2018
@jgravois
refactor(reorganizing): break up geocoding package into multiple files
216f23c 
AFFECTS PACKAGES:
@esri/arcgis-rest-geocoder

ISSUES CLOSED: #216
@jgravois jgravois mentioned this issue Jun 12, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgravois jgravois

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jgravois