-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation pages navigation: highlight currently selected page #284
Comments
definitely a good suggestion. |
The highlighting actually works if you run the docs locally. I think we need to change something in the calcite web configuration so it works in both environments. |
the problem is worse than that. proposed |
looks great @jgravois! |
I hate to even bring this up, but in FF I can get the nav in a state where both nav links appear active by going from one to the other and then using the back button (or key board shortcut): As long as navigate back/forward using the built in browser controls both continue to appear active, but when I click on either one, only that one will be appear active. Other than that this looks great, and I'm not even sure a fix for ^^^ is worth the trouble. |
I'll admit this is a subjective request, but I personally find it easier when the page I'm on highlights itself in the navigation. It helps me get my bearings if maybe I arrived on this page from a search engine or outside link. So I would propose changing this:
to something like this:
(notice the background highlight on the selected page in the nav)
Just throwing it out there to see what you all think! Thanks!
The text was updated successfully, but these errors were encountered: