Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(items): dont override user supplied parameters when updating items #120

Merged
merged 1 commit into from
Feb 23, 2018

Conversation

jgravois
Copy link
Contributor

@jgravois jgravois commented Feb 22, 2018

AFFECTS PACKAGES:
@esri/arcgis-rest-items

ISSUES CLOSED: #117

to be honest, mixing in a properly serialized item like this seems a little strange.

requestOptions.params = {
    ...requestOptions.params,
    ...serializeItem(requestOptions.item)
  };

@coveralls
Copy link

coveralls commented Feb 22, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling fc55db0 on patch117 into 52caf83 on master.

@Esri Esri deleted a comment from coveralls Feb 22, 2018
@jgravois jgravois mentioned this pull request Feb 23, 2018
@jgravois
Copy link
Contributor Author

added additional fixes (and tests) for

  • addItemJsonData()
  • getItemResources()
  • updateItemResource()
  • removeItemResource()

@noahmulfinger
Copy link
Contributor

@jgravois searchItems still needs fixing, but it looks like that's the last one.

Copy link
Contributor

@noahmulfinger noahmulfinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked with @jgravois, searchItems is fine. LGTM!

AFFECTS PACKAGES:
@esri/arcgis-rest-items

ISSUES CLOSED: #117
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants