Updated the vanilla JS demo. #140
Conversation
|
Realized when the session was being placed into local storage the expiration date was being stringified. Last commit now creates a new date from that string when parsing the serialized session on page load. |
| <script src="node_modules/@esri/arcgis-rest-auth/dist/umd/arcgis-rest-auth.umd.js"></script> | ||
| <script> | ||
| const match = window.location.href.match( | ||
| /clientID=(.+)#/ |
There was a problem hiding this comment.
We should add a comment here that this should usually be hardcoded.
| session = arcgisRest.UserSession.completeOAuth2({ | ||
| clientId, | ||
| }); | ||
| localStorage.setItem('__ARCGIS_REST_USER_SESSION__', JSON.stringify(session)); |
There was a problem hiding this comment.
session has a serialize method that could be used here like session.serialize() we should show that instead https://esri.github.io/arcgis-rest-js/api/auth/UserSession/#serialize.
| const clientId = match[1]; | ||
| let session; | ||
| function processAuthentication() { | ||
| session = arcgisRest.UserSession.completeOAuth2({ |
There was a problem hiding this comment.
This should probably come AFTER the local storage and window calls since it will call window.close() in somecases.
There was a problem hiding this comment.
i moved the window call, but we can't call session.serialize() if the object isn't instantiated yet.
|
pushed another commit to incorporate @patrickarlt's (good) suggestions and rebased. |
Per discussion #138 (comment) this is an updated version of the vanilla js demo. Addresses #11 and should close #100. This implementation stores the session in localStorage and de-serializes it into a new session when not using a popup.
The general gist of OAuth is included, but with this being vanilla I wasn't going to go through the trouble of adding the same search functionality that I had added to the VueJS demo.