fix(auth): better regex match for usernames #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in OAuth responses usernames *might* be followed by additional parameters like persist=true or ssl=true, this regex ensures that they arent amended to usernames accidently AFFECTS PACKAGES: @esri/arcgis-rest-auth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in testing #140 i noticed that sometimes my username was being reported as
jgravois&persist=truewhen i ticked Keep me signed inthis regex ensures that additional parameters aren't appended to usernames accidentally when they are present by swapping in a match block that accepts anything except an
&.AFFECTS PACKAGES:
@esri/arcgis-rest-auth