Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(getPortalUrl): make getPortalUrl use portal in request options if passed in #181

Merged
merged 1 commit into from
May 2, 2018
Merged

fix(getPortalUrl): make getPortalUrl use portal in request options if passed in #181

merged 1 commit into from
May 2, 2018

Conversation

noahmulfinger
Copy link
Contributor

AFFECTS PACKAGES:
@esri/arcgis-rest-request

ISSUES CLOSED: #180

fix(getPortalUrl): make getPortalUrl use portal in request options if…
0e92b89 
… passed in

AFFECTS PACKAGES:
@esri/arcgis-rest-request

ISSUES CLOSED: #180
@noahmulfinger noahmulfinger requested a review from jgravois May 1, 2018 21:25
@coveralls
Copy link

coveralls commented May 1, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.002%) to 99.43% when pulling 0e92b89 on fix-180 into 1307329 on master.

jgravois
jgravois approved these changes May 1, 2018
View reviewed changes
Copy link
Contributor

@jgravois jgravois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@noahmulfinger noahmulfinger merged commit 6103101 into master May 2, 2018
@noahmulfinger noahmulfinger deleted the fix-180 branch May 2, 2018 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgravois jgravois jgravois approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noahmulfinger @coveralls @jgravois