-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crud param names #396
Fix crud param names #396
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work. thank you.
besides the small nitpick, this is good to go.
* | ||
* Array of JSON features to add. | ||
*/ | ||
adds?: IFeature[]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/**
* Deprecated. Please use `features` instead.
Array of JSON features to add.
these two will show up right next to each other in the API reference, so no need to repeat the meat of the description.
Hey @jgravois. I got a new work station. Build and test work just fine but I'm having issues running |
yup. acetate doesn't write output files to disk when you're running the dev server. they're only in memory ✨. its a bit of a gotcha, but until patrickarlt/acetate#74 lands, we all have to tack |
It must have just opened |
nah, its a regression i introduced in #341. if you could make the breadcrumb i already dropped more explicit, it would be sincerely appreciated. |
That looks good to me @jgravois. Had I seen that I would have known. |
Per #391