Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crud param names #396

Merged
merged 2 commits into from
Nov 19, 2018
Merged

Fix crud param names #396

merged 2 commits into from
Nov 19, 2018

Conversation

COV-GIS
Copy link
Contributor

@COV-GIS COV-GIS commented Nov 19, 2018

Per #391

@coveralls
Copy link

coveralls commented Nov 19, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 3221ea7 on COV-GIS:fix-crud-param-names into 17899dc on Esri:master.

Copy link
Contributor

@jgravois jgravois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work. thank you.

besides the small nitpick, this is good to go.

*
* Array of JSON features to add.
*/
adds?: IFeature[];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/**
* Deprecated. Please use `features` instead.

Array of JSON features to add.

these two will show up right next to each other in the API reference, so no need to repeat the meat of the description.

@COV-GIS
Copy link
Contributor Author

COV-GIS commented Nov 19, 2018

Hey @jgravois. I got a new work station. Build and test work just fine but I'm having issues running docs:serve to check the docs. All the tasks run w/o error. typedoc.json is created. The assets are all copied. But no html files are being generated. Any thoughts on why?

@jgravois
Copy link
Contributor

no html files are being generated. Any thoughts on why?

yup. acetate doesn't write output files to disk when you're running the dev server. they're only in memory ✨.

its a bit of a gotcha, but until patrickarlt/acetate#74 lands, we all have to tack /arcgis-rest-js/ onto the url thats spawned manually.

http://localhost:3000/arcgis-rest-js/

@COV-GIS
Copy link
Contributor Author

COV-GIS commented Nov 19, 2018

It must have just opened http://localhost:3000/arcgis-rest-js/ on my old machine. Thanks.

@jgravois
Copy link
Contributor

It must have just opened http://localhost:3000/arcgis-rest-js/ on my old machine. Thanks.

nah, its a regression i introduced in #341.

if you could make the breadcrumb i already dropped more explicit, it would be sincerely appreciated.

@COV-GIS
Copy link
Contributor Author

COV-GIS commented Nov 19, 2018

That looks good to me @jgravois. Had I seen that I would have known.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants