Revert Merge pull request #656 to remove const enums usage. #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subgan82
changed the title
Codecov Report
@@ Coverage Diff @@
## master #681 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 107 106 -1
Lines 1616 1613 -3
Branches 286 286
=========================================
- Hits 1616 1613 -3
Continue to review full report at Codecov.
|
maneetgoyal
reviewed
Apr 2, 2020
|
All the changes introduced by this PR #656 has been reverted here. |
patrickarlt
reviewed
Apr 3, 2020
There was a problem hiding this comment.
Looks good to me. I'll let someone else (@tomwayson maybe?) review and deploy this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit f3f856b, reversing
changes made to 8a2daac.
Based on this discussion #668 (comment)
#668 (comment)
Const Enums cannot be used by babel.