Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UserSession token duration for oauth #841

Merged
merged 3 commits into from
May 17, 2021
Merged

Conversation

hogpilot
Copy link
Contributor

Addresses an issue where token duration was not honored in oauth flow due to improper `duration`

AFFECTS PACKAGES:
@esri/arcgis-rest-auth

ISSUES CLOSED: #840

@codecov
Copy link

codecov bot commented May 13, 2021

Codecov Report

Merging #841 (efaf6cc) into master (e59e499) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #841   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          133       133           
  Lines         2352      2352           
  Branches       415       415           
=========================================
  Hits          2352      2352           
Impacted Files Coverage Δ
packages/arcgis-rest-auth/src/UserSession.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e59e499...efaf6cc. Read the comment docs.

Copy link
Contributor

@noahmulfinger noahmulfinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@tomwayson tomwayson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hogpilot - I can't believe no one has caught this up until now.

We should add an issue to add an expiration to and deprecate duration from IOAuth2Options.

@gavinr gavinr merged commit 3f43679 into Esri:master May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Token duration is improperly set in ouath/authorize workflow
4 participants