diff --git a/.github/workflows/add-esri-product-label.yml b/.github/workflows/add-esri-product-label.yml index f41f83ce83a..7587464f1cf 100644 --- a/.github/workflows/add-esri-product-label.yml +++ b/.github/workflows/add-esri-product-label.yml @@ -56,19 +56,6 @@ jobs: }); } - /** remove any existing product label(s) */ - const existingProductLabels = currentLabels - .filter((l) => /Issues logged by/.test(l.description) && l.name !== product) - .forEach( - async (l) => - await github.rest.issues.removeLabel({ - issue_number, - owner, - repo, - name: l.name, - }) - ); - /** add new product label */ await github.rest.issues.addLabels({ issue_number, diff --git a/.versionrc.json b/.versionrc.json index beba780fd88..b1874236dfe 100644 --- a/.versionrc.json +++ b/.versionrc.json @@ -6,7 +6,7 @@ "changelog": true }, "scripts": { - "precommit": "ts-node --esm ./support/prepReleaseCommit.ts" + "precommit": "ts-node --esm ./support/prepReleaseCommit.ts && npm run lint:md && git add readme.md CHANGELOG.md" }, "header": "# Changelog\n\nThis document maintains a list of released versions and changes introduced by them.\nThis project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html)\n\n" } diff --git a/src/components/input-number/input-number.tsx b/src/components/input-number/input-number.tsx index f1ff1e09112..300ef5f43e9 100644 --- a/src/components/input-number/input-number.tsx +++ b/src/components/input-number/input-number.tsx @@ -131,7 +131,9 @@ export class InputNumber @Prop({ reflect: true }) hidden = false; /** - * When `true`, shows a default recommended icon. Alternatively, pass a Calcite UI Icon name to display a specific icon. + * Specifies an icon to display. + * + * @futureBreaking Remove boolean type as it is not supported. */ @Prop({ reflect: true }) icon: string | boolean; @@ -808,7 +810,7 @@ export class InputNumber }; const sanitizedValue = sanitizeNumberString( - // no need to delocalize a string that ia already in latn numerals + // no need to delocalize a string that ia already in latn numerals (this.numberingSystem && this.numberingSystem !== "latn") || defaultNumberingSystem !== "latn" ? numberStringFormatter.delocalize(value) : value diff --git a/src/components/input-text/input-text.tsx b/src/components/input-text/input-text.tsx index b5afa9f234f..b4b61dbe860 100644 --- a/src/components/input-text/input-text.tsx +++ b/src/components/input-text/input-text.tsx @@ -109,7 +109,9 @@ export class InputText @Prop({ reflect: true }) hidden = false; /** - * When `true`, shows a default recommended icon. Alternatively, pass a Calcite UI Icon name to display a specific icon. + * Specifies an icon to display. + * + * @futureBreaking Remove boolean type as it is not supported. */ @Prop({ reflect: true }) icon: string | boolean;