From 97d0631e77b4c92192102f5102ab96e2c74c508c Mon Sep 17 00:00:00 2001 From: Ben Elan Date: Thu, 2 Feb 2023 12:46:39 -0600 Subject: [PATCH 1/3] ci: allow multiple product team labels (#6411) **Related Issue:** # ## Summary Allows multiple product team labels, as requested in the Operational Update chat. Note it would only remove other product team labels if the issue body was edited. I set that up in case someone set the wrong team or something --- .github/workflows/add-esri-product-label.yml | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/.github/workflows/add-esri-product-label.yml b/.github/workflows/add-esri-product-label.yml index f41f83ce83a..7587464f1cf 100644 --- a/.github/workflows/add-esri-product-label.yml +++ b/.github/workflows/add-esri-product-label.yml @@ -56,19 +56,6 @@ jobs: }); } - /** remove any existing product label(s) */ - const existingProductLabels = currentLabels - .filter((l) => /Issues logged by/.test(l.description) && l.name !== product) - .forEach( - async (l) => - await github.rest.issues.removeLabel({ - issue_number, - owner, - repo, - name: l.name, - }) - ); - /** add new product label */ await github.rest.issues.addLabels({ issue_number, From 771a988f899c64d5d7c6882c585034944f9da218 Mon Sep 17 00:00:00 2001 From: Ben Elan Date: Thu, 2 Feb 2023 12:48:14 -0600 Subject: [PATCH 2/3] ci(release): lint readme and changelog before committing (#6406) **Related Issue:** #6355 ## Summary I added markdown lint in the PR above but it isn't running during releases because we have `standard-version` set to `noVerify`. So this is manually linting the readme/changelog before committing. --- .versionrc.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.versionrc.json b/.versionrc.json index beba780fd88..b1874236dfe 100644 --- a/.versionrc.json +++ b/.versionrc.json @@ -6,7 +6,7 @@ "changelog": true }, "scripts": { - "precommit": "ts-node --esm ./support/prepReleaseCommit.ts" + "precommit": "ts-node --esm ./support/prepReleaseCommit.ts && npm run lint:md && git add readme.md CHANGELOG.md" }, "header": "# Changelog\n\nThis document maintains a list of released versions and changes introduced by them.\nThis project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html)\n\n" } From f69995e7206577c34ba47df70e6b23626c494d8e Mon Sep 17 00:00:00 2001 From: Eliza Khachatryan Date: Thu, 2 Feb 2023 19:18:37 -0800 Subject: [PATCH 3/3] docs(input-number, input-text): remove unsupported boolean type from type prop doc (#6394) **Related Issue:** #6386 ## Summary In the future, we will be removing the support of the `boolean` type for the `icon` prop on `input-number` and `input-text` as these don't have a `default` recommended icon for an unspecified icon attribute and result in unwanted spacing preceding the `input`. For now though, since it is potentially a minor breaking change that could possibly be in use somewhere, we removed the `boolean` scenario from the documentation and marked it with a newly introduced custom `@futureBreaking` tag. --- src/components/input-number/input-number.tsx | 6 ++++-- src/components/input-text/input-text.tsx | 4 +++- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/src/components/input-number/input-number.tsx b/src/components/input-number/input-number.tsx index f1ff1e09112..300ef5f43e9 100644 --- a/src/components/input-number/input-number.tsx +++ b/src/components/input-number/input-number.tsx @@ -131,7 +131,9 @@ export class InputNumber @Prop({ reflect: true }) hidden = false; /** - * When `true`, shows a default recommended icon. Alternatively, pass a Calcite UI Icon name to display a specific icon. + * Specifies an icon to display. + * + * @futureBreaking Remove boolean type as it is not supported. */ @Prop({ reflect: true }) icon: string | boolean; @@ -808,7 +810,7 @@ export class InputNumber }; const sanitizedValue = sanitizeNumberString( - // no need to delocalize a string that ia already in latn numerals + // no need to delocalize a string that ia already in latn numerals (this.numberingSystem && this.numberingSystem !== "latn") || defaultNumberingSystem !== "latn" ? numberStringFormatter.delocalize(value) : value diff --git a/src/components/input-text/input-text.tsx b/src/components/input-text/input-text.tsx index b5afa9f234f..b4b61dbe860 100644 --- a/src/components/input-text/input-text.tsx +++ b/src/components/input-text/input-text.tsx @@ -109,7 +109,9 @@ export class InputText @Prop({ reflect: true }) hidden = false; /** - * When `true`, shows a default recommended icon. Alternatively, pass a Calcite UI Icon name to display a specific icon. + * Specifies an icon to display. + * + * @futureBreaking Remove boolean type as it is not supported. */ @Prop({ reflect: true }) icon: string | boolean;