Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Research: Research using different focus trap npm helper #1169

Closed
driskull opened this issue Oct 22, 2020 · 6 comments
Closed

Research: Research using different focus trap npm helper #1169

driskull opened this issue Oct 22, 2020 · 6 comments
Assignees
@geospatialem @benelan
Labels
4 - verified Issues that have been released and confirmed resolved.

Comments

@driskull
Copy link
Member

Background

Research: Research using different focus trap npm helper

https://www.npmjs.com/package/focus-trap

Desired Outcome

Using best focus trap helper
@driskull driskull added the research Issues that require more in-depth research or multiple team members to resolve or make decision. label Oct 22, 2020
@driskull driskull self-assigned this Oct 22, 2020
@driskull
Copy link
Member Author

@jcfranco I tried using the other focus trap package without any luck. The problem is that I couldn't find a good way to start the focus trap after the modal becomes active but after DOM nodes were already created or updated.

Do you want to take a stab at it?

@driskull
Copy link
Member Author

driskull commented Nov 20, 2020 •
edited
Loading

I think the issue is with the tabbable dependency not supporting shadow dom.

@driskull driskull added this to the Backlog milestone Dec 31, 2020
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Feb 26, 2021
@driskull
Copy link
Member Author

Going to close this until the focus helper supports shadow dom.

@driskull driskull reopened this Nov 1, 2022
@driskull driskull added 0 - new New issues that need assignment. and removed research Issues that require more in-depth research or multiple team members to resolve or make decision. Stale Issues or pull requests that have not had recent activity. labels Nov 1, 2022
@driskull driskull removed this from the Freezer milestone Nov 1, 2022
@driskull driskull mentioned this issue Nov 1, 2022
Merged
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 0 - new New issues that need assignment. labels Nov 16, 2022
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem
Copy link
Member

Works great! Verified in beta.98 in Chrome, Firefox, and Edge browsers.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@benelan benelan

Labels
4 - verified Issues that have been released and confirmed resolved.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@driskull @geospatialem @benelan