-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include slot for inline 'info icon' before or after label text. #4155
Comments
Thanks for submitting, this is a common use case ... could you add designs for the other layouts of input - inline and inline-space-between? Additionally, the label text (or multiple strings) and child control can be placed in any order, so comps that show some less common arrangements could help us understand where to position the named slot. I anticipate this will be very commonly used and because of the often tight confines of where it will be used we may want to be somewhat strict in our styling ruleset of the slot. To complicate things for ya @mitc7862 - the design should probably encapsulate some of what was proposed here #2793 - These two elements will likely co-exist at times. …as a note, you can already do this, you just need to wrap these elements in a div and position as needed. |
When you say build custom input labels, do you mean just slot the div inside a https://jsbin.com/zexapenizo/1/edit?html,output I think the issue with potentially styling or placing a named slot is that, like in Mitch's example, there are many potentially valid placements for the tooltip-launching-icon. |
We could certainly start with one as an opinionated pattern that we all use. |
Is there any status on this? Field Maps is having to handle this currently with custom inputs. |
No update at this time. As an implementation note for when this is looked at - the label functionality to focus the child control may need to have an "exclusionary click zone" or something along those lines to ensure clicking on a, tooltip trigger, for example, doesn't focus the control. |
Adding the slot will require a major refactor, and will be prioritized after next month's release. cc: @ashetland, @Elijbet Once prioritized the effort should be coupled with #2793 and #5079. |
Closing in favor of #5079. |
Description
For analysis, we will need to provide parameter-based help for various inputs in the form. We'd like to include an inline action that triggers a popover with the helpful information in it.
Acceptance Criteria
Relevant Info
No response
Which Component
Label
Example Use Case
The text was updated successfully, but these errors were encountered: