Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Eslint] Add rule for consistent tabIndex formatting #7631

Closed
macandcheese opened this issue Aug 30, 2023 · 3 comments
Closed

[Eslint] Add rule for consistent tabIndex formatting #7631

macandcheese opened this issue Aug 30, 2023 · 3 comments
Labels
0 - new New issues that need assignment. eslint-plugin-calcite-components Issues specific to the @esri/eslint-plugin-calcite-components package. estimate - 2 Small fix or update, may require updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - low Issue is non core or affecting less that 10% of people using the library tooling Issues relating to build system fixes or improvements.
Milestone
Stalled

Comments

@macandcheese
Copy link
Contributor

macandcheese commented Aug 30, 2023 •
edited
Loading

Summary

Across the library we currently have a lot of tabindex and tabIndex used.

Desired Outcome

Add a linting rule for correct tabIndex casing.

Resources

cc @driskull
@macandcheese macandcheese added tooling Issues relating to build system fixes or improvements. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Aug 30, 2023
@macandcheese macandcheese mentioned this issue Aug 30, 2023
Merged
@jcfranco jcfranco added the eslint-plugin-calcite-components Issues specific to the @esri/eslint-plugin-calcite-components package. label Aug 31, 2023
@geospatialem geospatialem added p - low Issue is non core or affecting less that 10% of people using the library estimate - 2 Small fix or update, may require updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Jun 25, 2024
@jcfranco
Copy link
Member

Blocked by #10310.

@jcfranco jcfranco added the blocked This issue is blocked by another issue. label Sep 27, 2024
@jcfranco jcfranco mentioned this issue Sep 27, 2024
Closed
@geospatialem geospatialem added this to the Stalled milestone Sep 27, 2024
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Sep 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

Issue #10310 has been closed, this issue is ready for re-evaluation.

cc @geospatialem,@DitwanP

@github-actions github-actions bot removed the blocked This issue is blocked by another issue. label Nov 26, 2024
@geospatialem geospatialem added the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Nov 26, 2024
@jcfranco
Copy link
Member

Lumina enforces prop-usage, so this is no longer needed. 🎉 Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. eslint-plugin-calcite-components Issues specific to the @esri/eslint-plugin-calcite-components package. estimate - 2 Small fix or update, may require updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - low Issue is non core or affecting less that 10% of people using the library tooling Issues relating to build system fixes or improvements.
Projects
None yet
Milestone
Stalled
Development

No branches or pull requests
3 participants
@jcfranco @macandcheese @geospatialem