Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Block-section] Apply missing CSS class to start/end icon #9703

Closed
2 of 6 tasks
Elijbet opened this issue Jun 26, 2024 · 2 comments
Closed
2 of 6 tasks

[Block-section] Apply missing CSS class to start/end icon #9703

Elijbet opened this issue Jun 26, 2024 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - low Issue is non core or affecting less that 10% of people using the library
Milestone
2024-07-31 - Jul ...

Comments

@Elijbet
Copy link
Contributor

Elijbet commented Jun 26, 2024 •
edited
Loading

Check existing issues

Actual Behavior

Icon uses class instead of value for styling.

Expected Behavior

Update to use class.

Reproduction Sample

https://codepen.io/jcfranco/pen/vYwoOaW?editors=1000

Priority impact

impact - p3 - not time sensitive

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (dev)
@Elijbet Elijbet added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jun 26, 2024
@github-actions github-actions bot added Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Jun 26, 2024
@Elijbet Elijbet changed the title Apply missing CSS class to start/end icon [Block-section] Apply missing CSS class to start/end icon Jun 26, 2024
@Elijbet Elijbet mentioned this issue Jun 26, 2024
Merged
jcfranco added a commit that referenced this issue Jul 1, 2024
@jcfranco
fix(block-section): apply missing CSS class to start/end icon (#9688)
bceeab5 
**Related Issue:** #9703

## Summary

Updates icon rendering to use class instead of value for styling.
@jcfranco jcfranco added p - low Issue is non core or affecting less that 10% of people using the library 2 - in development Issues that are actively being worked on. estimate - 2 Small fix or update, may require updates to tests. and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jul 1, 2024
@jcfranco jcfranco added this to the 2024-07-30 - Jul Release milestone Jul 1, 2024
@jcfranco jcfranco self-assigned this Jul 1, 2024
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jul 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 1, 2024

Installed and assigned for verification.

@DitwanP
Copy link
Contributor

DitwanP commented Jul 3, 2024

🍡 Verified on 2.11.0-next.0

@DitwanP DitwanP closed this as completed Jul 3, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jul 3, 2024
calcite-admin pushed a commit that referenced this issue Jul 30, 2024
@jcfranco @github-actions
fix(block-section): apply missing CSS class to start/end icon (#9688)
2169ed2 
**Related Issue:** #9703

## Summary

Updates icon rendering to use class instead of value for styling.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - low Issue is non core or affecting less that 10% of people using the library
Projects
None yet
Milestone
2024-07-31 - Jul Release
Development

No branches or pull requests
4 participants
@jcfranco @geospatialem @Elijbet @DitwanP