Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪲 Bug regarding squished images #29

Closed
EssamWisam opened this issue Nov 16, 2023 · 3 comments · Fixed by #30 or #47
Closed

🪲 Bug regarding squished images #29

EssamWisam opened this issue Nov 16, 2023 · 3 comments · Fixed by #30 or #47
Assignees
Labels
bug Something isn't working

Comments

@EssamWisam
Copy link
Owner

EssamWisam commented Nov 16, 2023

image

I sometimes find unloaded images as in the image above, especially in the other classes' pages. Checked out previous PRs and it seems like that the problem was there from the beginning, we just didn't notice it. So, I would assume that the invalid images are from the website that creates these placeholder images. Not sure if we should check for that as well or just opt for reloading the page (and so getting another seed which will highly be a valid image).

Originally posted by @Iten-No-404 in #28 (comment)_

@EssamWisam
Copy link
Owner Author

EssamWisam commented Nov 16, 2023

we can either check for the validity of the placeholder image or use another placeholder website.

Will explore solutions to this problem. Could be that the server for the placeholder images is a little funny because to me this happens really inconsistently (switching pages or refreshing often makes it go) and sometimes it doesn't occur in the first place.

I would deprioritize looking for another one because I remember spending a reasonable amount of time looking for visually pleasing placeholder images, most of them were far inferior to this.

@EssamWisam EssamWisam added the bug Something isn't working label Nov 16, 2023
@Iten-No-404
Copy link
Collaborator

Will explore solutions to this problem. Could be that the server for the placeholder images is a little funny because to me this happens really inconsistently (switching pages or refreshing often makes it go) and sometimes it doesn't occur in the first place.

You're right. It could possibly be their server or a mere connection issue. This issue has the least priority among all the other ones since it rarely happens.

@Iten-No-404 Iten-No-404 linked a pull request Nov 16, 2023 that will close this issue
@EssamWisam
Copy link
Owner Author

Looks like the virus is back!
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants