Skip to content
This repository has been archived by the owner on Oct 6, 2023. It is now read-only.

macOS requires manual iCloud group setting even though Info.plist autogenerates the correct one. #27

Open
EthanLipnik opened this issue Sep 13, 2021 · 9 comments · Fixed by #25

Comments

@EthanLipnik
Copy link
Owner

image

It seems that the only solution is to manually set the iCloud group. All the code should be working but for macOS it doesn't. Hopefully a new Xcode version will help. Opening an issue

Originally posted by @EthanLipnik in #25 (comment)

@EthanLipnik EthanLipnik linked a pull request Sep 13, 2021 that will close this issue
@EthanLipnik
Copy link
Owner Author

Seems to also effect iOS randomly

@feralbob
Copy link

I'm not seeing that issue (and I haven't whilst developing the PR)

Screen Shot 2021-09-12 at 10 32 23 PM

Note how it shows the $ at the end - indicating it came from the XCConfig

In the Apple dev account it shows the correct values

Screen Shot 2021-09-12 at 10 34 22 PM

What values are you seeing in the OpenSesameConfig.generated.swift file? Since I have to change all of the overrides to get it working in my dev account - I wonder if you're not overriding if one of the values isn't set.

I have

struct OpenSesameConfig { 
  fileprivate init() {}
    static let PRODUCT_BUNDLE_IDENTIFIER_BASE = "ca.shand.OpenSesame"
    static let TEAM_IDENTIFIER = "7GMH2FWQ44"
    static let APP_GROUP = "group.OpenSesame.shand"
}

@EthanLipnik
Copy link
Owner Author

The values in the generated file are correct for me, the project won't update to them

@feralbob
Copy link

Might be worth double checking in the build settings that there isn't a hard coded value somewhere. The Mac client might still have hard coded values for PRODUCT_BUNDLE_IDENTIFIER for the release configuration.

Happy to try pairing sometime to see if we can work it out.

@EthanLipnik
Copy link
Owner Author

image

Not sure if it's related but I can't run Xcode Previews anymore. Works in the simulator

@EthanLipnik
Copy link
Owner Author

image

Just tried a fresh clone and the iCloud issue still remains. Might need to have the iCloud part hard coded until we figure out the automated part

@feralbob
Copy link

OK - let me upgrade to the latest RCs and I'll take another look.

@feralbob
Copy link

OK - let me upgrade to the latest RCs and I'll take another look.

/me twiddles thumbs as things download and install.

@EthanLipnik
Copy link
Owner Author

I've been trying with the RC but can't seem to figure it out. Also effecting iOS now

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants