Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: impl fundamental signature verification modes #1

Merged
merged 19 commits into from
Jun 1, 2023
Merged

Conversation

EthanYuan
Copy link
Owner

Based on dynamic linking, the following 3 modes of otx locking scripts are implemented

1 compatible mode: fully compatible with secp256k1_blake2b_sighash_all
2 sighash mode: Single | AnyoneCanPay
3 sighash mode: ALL | AnyoneCanPay

@EthanYuan EthanYuan changed the title feat: impl 3 modes feat: impl fundamental signature verification modes May 22, 2023
@EthanYuan EthanYuan marked this pull request as ready for review May 22, 2023 03:11
@EthanYuan EthanYuan requested a review from doitian May 22, 2023 03:11
@doitian
Copy link
Collaborator

doitian commented Jun 1, 2023

Let's call it otx-sighash-lock to differentiate it with the commands-list version.

@EthanYuan
Copy link
Owner Author

Let's call it otx-sighash-lock to differentiate it with the commands-list version.

Done

Copy link
Collaborator

@doitian doitian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Posted two minor suggestions.

contracts/otx-lock/src/helper.rs Outdated Show resolved Hide resolved
contracts/otx-lock/src/validate/sighash_all_acp.rs Outdated Show resolved Hide resolved
@EthanYuan EthanYuan merged commit 82e3874 into main Jun 1, 2023
@EthanYuan EthanYuan deleted the dl-secp256k1 branch June 1, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants