Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why does russh_keys::key::KeyPair::generate_ed25519 return an Option? #338

Closed
nicmr opened this issue Sep 10, 2024 · 0 comments
Closed

Why does russh_keys::key::KeyPair::generate_ed25519 return an Option? #338

nicmr opened this issue Sep 10, 2024 · 0 comments

Comments

@nicmr
Copy link
Contributor

nicmr commented Sep 10, 2024

It calls ed25519_dalek::SigningKey::generate internally, which cannot fail. Is it to have the same Signature as generate_rsa? If yes, is that valuable? It seems more ergonomic to me if infallible operations don't return an Option.

@Eugeny Eugeny closed this as completed in cb8d9e9 Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant