-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switching pane-maximize will add an additional line break in the new window #8071
Comments
@Eugeny Can I take this issue? |
of course! |
@Eugeny Can you provide some advice that where all the key strokes are handled? |
All hotkeys are handled in https://github.com/Eugeny/tabby/blob/master/tabby-core/src/services/hotkeys.service.ts , the likely solution is to
|
I tried to figure out where those keyboard event is propagated in tabby/tabby-terminal/src/api/baseTerminalTab.component.ts Lines 439 to 447 in fac6ec5
Is this right place to start? 🤔 @Eugeny |
Not exactly, xterm is listening to keyboard events directly, so terminal input doesn't to through tabby code, but I'm intercepting all keys in HotkeyService first, where, if a key matches a known shortcut, it should be cancelled and never make it's way into xterm |
Got it. 👍 |
Got it. 👍 |
If I commented out these lines, this bug is removed but simply removing these lines is definitely not the solution. tabby/tabby-core/src/services/hotkeys.service.ts Lines 181 to 184 in fac6ec5
|
Taking these lines out won't do anything for other operating systems unfortunately, as macOS is the only one with this problem. On other OSes, |
Describe the problem:
Switching pane-maximize will add an additional line break in the new window, which can be solved by changing a shortcut key, but I'm still used to the combination of cmd option enter.
To Reproduce:
split window>cmd option enter * n
The text was updated successfully, but these errors were encountered: