Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate from moment to date-fns #988

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Conversation

nosovk
Copy link
Contributor

@nosovk nosovk commented May 16, 2024

Last years there are some alternatives to momentjs appeared. Like date-fns. Mostly they depend on new itnl, that is build in into all modern browsers.

Unfortunately, I wasn't able to build the project (I've never touched rust before, and the current cargo version refused to accept configs from repo).

That's why I'm not sure that this PR actually works :(

If somebody can check, that it builds correctly now - it would be nice to move to less size costly solution like date-fns.

@nosovk
Copy link
Contributor Author

nosovk commented May 16, 2024

It seems that sonar has failed because of SONAR_TOKEN env variable missing, it seems that error not related to PR.

@Eugeny
Copy link
Member

Eugeny commented Jul 16, 2024

Thank you!

@all-contributors please add @nosovk for code

@Eugeny Eugeny merged commit 7e45fa5 into warp-tech:main Jul 16, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants