Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ssh): make inactivity timeout configurable #990

Merged
merged 1 commit into from
May 31, 2024

Conversation

NefixEstrada
Copy link
Contributor

With this change, the SSH inactivity timeout is now configurable. By default, is set at 5 minutes (300 seconds), which was the already existing value.

Solves #943

With this change, the SSH inactivity timeout is now configurable. By
default, is set at 5 minutes (300 seconds), which was the already
existing value.
@Eugeny
Copy link
Member

Eugeny commented May 31, 2024

Thank you!

@Eugeny Eugeny merged commit 9582a6e into warp-tech:main May 31, 2024
5 of 7 checks passed
@przemekjagielski
Copy link

Are you sure, this change is workly? I tested this change and session was killed after 5 minute.

@przemekjagielski
Copy link

@Eugeny

@NefixEstrada
Copy link
Contributor Author

Are you sure, this change is workly? I tested this change and session was killed after 5 minute.

We've had this in production for some weeks and is working correctly. Did you change the configuration value in the YAML file?

@przemekjagielski
Copy link

ssh: enable: true listen: "0.0.0.0:2222" keys: /data/ssh-keys host_key_verification: prompt inactivity_timeout: 86400

@NefixEstrada
Copy link
Contributor Author

ssh: enable: true listen: "0.0.0.0:2222" keys: /data/ssh-keys host_key_verification: prompt inactivity_timeout: 86400

It needs to be in a valid humantime format: https://docs.rs/humantime/latest/humantime/fn.parse_duration.html

For example, we've set it up as inactivity_timeout: 30m

@przemekjagielski
Copy link

I changed this but again it not works. I see, PR have status failed. Maybe this change is not in main branch?

@przemekjagielski
Copy link

Any update? @NefixEstrada @Eugeny

@Eugeny
Copy link
Member

Eugeny commented Jun 21, 2024

@przemekjagielski post your config file

@przemekjagielski
Copy link

`

sso_providers: []
recordings:
enable: true
path: /data/recordings
external_host: ~
database_url: "mysql://warpgate:PASSWORD@mariadb/warpgate"
ssh:
enable: true
listen: "0.0.0.0:2222"
keys: /data/ssh-keys
host_key_verification: prompt
inactivity_timeout: 30m
http:
enable: true
listen: "0.0.0.0:8888"
certificate: /data/tls.certificate.pem
key: /data/tls.key.pem
trust_x_forwarded_headers: false
mysql:
enable: true
listen: "0.0.0.0:33306"
certificate: /data/tls.certificate.pem
key: /data/tls.key.pem
log:
retention: 7days
send_to: ~
config_provider: database`

@NefixEstrada
Copy link
Contributor Author

Here's my configuration file for ssh:

ssh:
  enable: true
  listen: "0.0.0.0:2222"
  keys: /var/lib/warpgate/ssh-keys
  host_key_verification: prompt
  inactivity_timeout: 30m

Which version are you using? Did you compile from the main branch? Because there hasn't been a release since december, which doesn't have the changes in this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants