Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure only last target certificate in multi-target project #19

Open
mabounassif opened this issue Jan 13, 2024 · 1 comment · May be fixed by #20
Open

Configure only last target certificate in multi-target project #19

mabounassif opened this issue Jan 13, 2024 · 1 comment · May be fixed by #20

Comments

@mabounassif
Copy link

There's a bug that only configures the certificates of the last target scanned by the plugin.
@mabounassif mabounassif linked a pull request Jan 13, 2024 that will close this issue
Open
@nixolas1
Copy link

Some context for how this worked for us:
The plugin overwrote other plugin's certificate config in the extras.
Would be nice to merge the fix! (and maybe make it a bit more readable, never seen [value!] or ||=

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bug: only set value of last segment if not initialized mabounassif/expo-apple-targets
2 participants
@mabounassif @nixolas1