Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TYPES] Implement Decimal128 dtype #934

Closed
samster25 opened this issue May 18, 2023 · 1 comment
Closed

[TYPES] Implement Decimal128 dtype #934

samster25 opened this issue May 18, 2023 · 1 comment
Assignees
@xcharleslin
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@samster25
Copy link
Member

samster25 commented May 18, 2023 •
edited
Loading

Looks like arrow2 does have it: https://github.com/jorgecarleitao/arrow2/blob/main/src/datatypes/mod.rs#L156

but it is backed by Int128 and Int256 so we have to implement those first
@samster25 samster25 changed the title Implement Decimal128 dtype Implement Decimal[128, 256] dtype May 18, 2023
@samster25 samster25 mentioned this issue May 18, 2023
Closed
@samster25 samster25 added enhancement New feature or request good first issue Good for newcomers labels May 18, 2023
@jaychia jaychia added this to Daft-OSS Jul 9, 2023
@jaychia jaychia mentioned this issue Jul 9, 2023
Merged
@jaychia jaychia moved this to Ready in Daft-OSS Jul 9, 2023
@jaychia jaychia changed the title Implement Decimal[128, 256] dtype [TYPES] Implement Decimal[128, 256] dtype Jul 9, 2023
@jaychia jaychia moved this from Ready to In progress in Daft-OSS Jul 10, 2023
@xcharleslin xcharleslin changed the title [TYPES] Implement Decimal[128, 256] dtype [TYPES] Implement Decimal128 dtype Jul 14, 2023
@xcharleslin
Copy link
Contributor

Splitting out Decimal128 and Decimal256.

Decimal128 is closed by #1129.

Decimal256 is open and will be a separate implementation: #1159

@jaychia jaychia moved this from In progress to Done in Daft-OSS Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xcharleslin xcharleslin

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
No open projects
Daft-OSS
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@samster25 @xcharleslin