Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop typing_compat dependency #498

Closed
mtitov opened this issue Jan 15, 2025 · 1 comment · Fixed by #499
Closed

Drop typing_compat dependency #498

mtitov opened this issue Jan 15, 2025 · 1 comment · Fixed by #499

Comments

@mtitov
Copy link

mtitov commented Jan 15, 2025

Could this dependency be dropped?
(https://github.com/ExaWorks/psij-python/blob/0.9.8/requirements.txt#L4)

This tool is archived, and if to keep PSI/J updated within the Spack, then need to bring this tool there as well (it is not there right now), but for an archived tool, I would propose to avoid it
@hategan
Copy link
Collaborator

hategan commented Jan 15, 2025 •
edited
Loading

Most likely droppable, but we might have to bump the minimum python version to 3.8. Given that 3.7 was EoL-ed, I think that should be reasonable.

@hategan hategan mentioned this issue Jan 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed dependency on typing_compat and bumped the minimum python ExaWorks/psij-python
2 participants
@mtitov @hategan