Skip to content
This repository has been archived by the owner on Jan 19, 2024. It is now read-only.

It should be easier to default to Fuel data version 1.1 #41

Closed
dougwilson opened this issue Mar 29, 2015 · 3 comments
Closed

It should be easier to default to Fuel data version 1.1 #41

dougwilson opened this issue Mar 29, 2015 · 3 comments
Assignees

Comments

@dougwilson
Copy link
Contributor

Right now, in order to ensure all requests just default to the (better) Fuel data version 1.1, the only good way looks stupid:

var FuelRest = require('fuel-rest');
var fuelRestClient = new FuelRest(options);

fuelRestClient.defaultHeaders['x-fueldata-version'] = '1.1';

I'm not sure if we should add an option explicitly for "fuelDataVersion", but at least if there was a constructor option to add to default headers, that would be a good general solution :)

@vernak2539
Copy link
Contributor

sounds like a really good idea. Will work on it

@vernak2539 vernak2539 self-assigned this Mar 29, 2015
vernak2539 added a commit to vernak2539/Fuel-Node-REST that referenced this issue Mar 29, 2015
@vernak2539
Copy link
Contributor

@dougwilson this what you were thinking? Ignore the module update in the previous commit

@dougwilson
Copy link
Contributor Author

Yep, looks fine to me :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants