Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test error with new version of CategoricalArrays.jl #51

Open
Felix-Gauthier opened this issue May 19, 2020 · 1 comment
Open

Unit test error with new version of CategoricalArrays.jl #51

Felix-Gauthier opened this issue May 19, 2020 · 1 comment

Comments

@Felix-Gauthier
Copy link

Arrow unit tests with CategoricalArrays v0.8.1 :

test results
(@v1.4) pkg> test Arrow
    Testing Arrow
Status `<path>\AppData\Local\Temp\jl_56sJoB\Manifest.toml`
  [69666777] Arrow v0.2.4
  [324d7699] CategoricalArrays v0.8.1
  [9a962f9c] DataAPI v1.3.0
  [682c06a0] JSON v0.21.0
  [e1d29d7a] Missings v0.4.3
  [69de0a69] Parsers v1.0.4
  [2a0f44e3] Base64
  [ade2ca70] Dates
  [8ba89e20] Distributed
  [9fa8497b] Future
  [b77e0a4c] InteractiveUtils
  [8f399da3] Libdl
  [37e2e46d] LinearAlgebra
  [56ddb016] Logging
  [d6f4376e] Markdown
  [a63ad114] Mmap
  [de0858da] Printf
  [9a3f8284] Random
  [9e88b42a] Serialization
  [6462fe0b] Sockets
  [2f01184e] SparseArrays
  [10745b16] Statistics
  [8dfed614] Test
  [4ec0a83e] Unicode
Test Summary:             | Pass  Total
indexing_Primitive_buffer |  260    260
Test Summary:                | Pass  Total
indexing_Primitive_construct |  260    260
Test Summary:               | Pass  Total
indexing_Primitive_setindex |  384    384
Test Summary:            | Pass  Total
indexing_Primitive_empty |    8      8
Test Summary:                     | Pass  Total
indexing_NullablePrimitive_buffer |  260    260
Test Summary:                        | Pass  Total
indexing_NullablePrimitive_construct |  260    260
Test Summary:                       | Pass  Total
indexing_NullablePrimitive_setindex |  384    384
Test Summary:                    | Pass  Total
indexing_NullablePrimitive_empty |    8      8
Test Summary:        | Pass  Total
indexing_List_buffer |   10     10
Test Summary:           | Pass  Total
indexing_List_construct |  260    260
Test Summary:       | Pass  Total
indexing_List_empty |    4      4
Test Summary:                | Pass  Total
indexing_NullableList_buffer |   12     12
Test Summary:                   | Pass  Total
indexing_NullableList_construct |  260    260
Test Summary:               | Pass  Total
indexing_NullableList_empty |    4      4
Test Summary:                | Pass  Total
indexing_BitPrimitive_buffer |   65     65
Test Summary:                   | Pass  Total
indexing_BitPrimitive_construct |  260    260
Test Summary:                        | Pass  Total
indexing_NullableBitPrimitive_buffer |   65     65
Test Summary:                           | Pass  Total
indexing_NullableBitPrimitive_construct |  260    260
Test Summary:                | Pass  Total
indexing_DictEncoding_buffer |   12     12
indexing_DictEncoding_construct: Error During Test at <path>\.julia\packages\Arrow\q3tEJ\test\indexing.jl:372
  Got exception outside of a @test
  type CategoricalPool has no field index
  Stacktrace:
   [1] getproperty(::CategoricalPool{Int64,UInt32,CategoricalValue{Int64,UInt32}}, ::Symbol) at .\Base.jl:33
   [2] getlevels(::CategoricalArray{Union{Missing, Int64},1,UInt32,Int64,CategoricalValue{Int64,UInt32},Missing}) at <path>\.julia\packages\Arrow\q3tEJ\src\dictencoding.jl:167
   [3] DictEncoding(::CategoricalArray{Union{Missing, Int64},1,UInt32,Int64,CategoricalValue{Int64,UInt32},Missing}) at <path>\.julia\packages\Arrow\q3tEJ\src\dictencoding.jl:68
   [4] top-level scope at <path>\.julia\packages\Arrow\q3tEJ\test\indexing.jl:374
   [5] top-level scope at D:\buildbot\worker\package_win64\build\usr\share\julia\stdlib\v1.4\Test\src\Test.jl:1113
   [6] top-level scope at <path>\.julia\packages\Arrow\q3tEJ\test\indexing.jl:373
   [7] include(::String) at .\client.jl:439
   [8] top-level scope at <path>\.julia\packages\Arrow\q3tEJ\test\runtests.jl:26
   [9] include(::String) at .\client.jl:439
   [10] top-level scope at none:6
   [11] eval(::Module, ::Any) at .\boot.jl:331
   [12] exec_options(::Base.JLOptions) at .\client.jl:264
   [13] _start() at .\client.jl:484

Test Summary:                   | Error  Total
indexing_DictEncoding_construct |     1      1
ERROR: LoadError: LoadError: Some tests did not pass: 0 passed, 0 failed, 1 errored, 0 broken.
in expression starting at <path>\.julia\packages\Arrow\q3tEJ\test\indexing.jl:372
in expression starting at <path>\.julia\packages\Arrow\q3tEJ\test\runtests.jl:26
ERROR: Package Arrow errored during testing

This error occurs following this change : JuliaData/CategoricalArrays.jl#253

@ExpandingMan
Copy link
Owner

Thanks, it really was not good of me to use internal fields like that. Shouldn't be too hard to fix, but I'm pretty deep in a major rewrite of this package (which so far I'm still hoping wont' depend on CategoricalArrays at all).

In the meantime, anything that doesn't involve dictionary-encoded columns should be unaffected by this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants