From f9e42fb5136f9be4bd0093a28859bced2d8f2240 Mon Sep 17 00:00:00 2001 From: dhairyasenjaliya Date: Fri, 23 Feb 2024 13:59:53 +0530 Subject: [PATCH] Add character limit on display name --- src/pages/settings/Profile/DisplayNamePage.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/pages/settings/Profile/DisplayNamePage.js b/src/pages/settings/Profile/DisplayNamePage.js index e8a1b5a39cfb..c443a91a7313 100644 --- a/src/pages/settings/Profile/DisplayNamePage.js +++ b/src/pages/settings/Profile/DisplayNamePage.js @@ -59,6 +59,8 @@ function DisplayNamePage(props) { // First we validate the first name field if (!ValidationUtils.isValidDisplayName(values.firstName)) { ErrorUtils.addErrorMessage(errors, 'firstName', 'personalDetails.error.hasInvalidCharacter'); + } else if (values.firstName.length > CONST.TITLE_CHARACTER_LIMIT) { + ErrorUtils.addErrorMessage(errors, 'firstName', ['common.error.characterLimitExceedCounter', {length: values.firstName.length, limit: CONST.TITLE_CHARACTER_LIMIT}]); } if (ValidationUtils.doesContainReservedWord(values.firstName, CONST.DISPLAY_NAME.RESERVED_NAMES)) { ErrorUtils.addErrorMessage(errors, 'firstName', 'personalDetails.error.containsReservedWord'); @@ -67,6 +69,8 @@ function DisplayNamePage(props) { // Then we validate the last name field if (!ValidationUtils.isValidDisplayName(values.lastName)) { ErrorUtils.addErrorMessage(errors, 'lastName', 'personalDetails.error.hasInvalidCharacter'); + } else if (values.lastName.length > CONST.TITLE_CHARACTER_LIMIT) { + ErrorUtils.addErrorMessage(errors, 'lastName', ['common.error.characterLimitExceedCounter', {length: values.lastName.length, limit: CONST.TITLE_CHARACTER_LIMIT}]); } if (ValidationUtils.doesContainReservedWord(values.lastName, CONST.DISPLAY_NAME.RESERVED_NAMES)) { ErrorUtils.addErrorMessage(errors, 'lastName', 'personalDetails.error.containsReservedWord'); @@ -107,7 +111,6 @@ function DisplayNamePage(props) { aria-label={props.translate('common.firstName')} role={CONST.ROLE.PRESENTATION} defaultValue={lodashGet(currentUserDetails, 'firstName', '')} - maxLength={CONST.DISPLAY_NAME.MAX_LENGTH} spellCheck={false} /> @@ -120,7 +123,6 @@ function DisplayNamePage(props) { aria-label={props.translate('common.lastName')} role={CONST.ROLE.PRESENTATION} defaultValue={lodashGet(currentUserDetails, 'lastName', '')} - maxLength={CONST.DISPLAY_NAME.MAX_LENGTH} spellCheck={false} />