From 136f34a59ed11cd0ddcc4993999cad8981ad54af Mon Sep 17 00:00:00 2001 From: Peter Velkov Date: Tue, 24 Aug 2021 10:37:59 +0300 Subject: [PATCH 1/2] Update CAPTURE_METRICS check in babel.config.js process.env values are always strings --- babel.config.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/babel.config.js b/babel.config.js index b10d59fa8934..dad806c0e416 100644 --- a/babel.config.js +++ b/babel.config.js @@ -41,7 +41,7 @@ const metro = { * By default is disabled in production as it adds small overhead * When CAPTURE_METRICS is set we're explicitly saying that we want to capture metrics * To enable the for release builds we add these aliases */ -if (process.env.CAPTURE_METRICS) { +if (process.env.CAPTURE_METRICS === 'true') { const path = require('path'); const profilingRenderer = path.resolve( __dirname, From c2d1d8e452348177081fafffe92f3da8c7ffa536 Mon Sep 17 00:00:00 2001 From: Peter Velkov Date: Tue, 24 Aug 2021 16:01:45 +0300 Subject: [PATCH 2/2] Add `react-native-flipper` to `includeModules` This prevents an error related to bundling: https://github.com/Expensify/App/pull/4760#issuecomment-904349442 --- config/webpack/webpack.common.js | 1 + 1 file changed, 1 insertion(+) diff --git a/config/webpack/webpack.common.js b/config/webpack/webpack.common.js index 8f608f694bc7..97f9eb948262 100644 --- a/config/webpack/webpack.common.js +++ b/config/webpack/webpack.common.js @@ -20,6 +20,7 @@ const includeModules = [ 'react-native-modal', 'react-native-onyx', 'react-native-gesture-handler', + 'react-native-flipper', ].join('|'); const webpackConfig = {