From 5bb58508f31992b0d4094e58bdf83581ae44ae6a Mon Sep 17 00:00:00 2001 From: kirillzyusko Date: Wed, 27 Mar 2024 15:44:40 +0100 Subject: [PATCH 1/2] fix: real startup metric --- src/Expensify.tsx | 2 ++ src/libs/actions/App.ts | 1 - 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/Expensify.tsx b/src/Expensify.tsx index 026025593aef..3843c12fdeb5 100644 --- a/src/Expensify.tsx +++ b/src/Expensify.tsx @@ -22,6 +22,7 @@ import * as Growl from './libs/Growl'; import Log from './libs/Log'; import migrateOnyx from './libs/migrateOnyx'; import Navigation from './libs/Navigation/Navigation'; +import Performance from './libs/Performance'; import NavigationRoot from './libs/Navigation/NavigationRoot'; import NetworkConnection from './libs/NetworkConnection'; import PushNotification from './libs/Notification/PushNotification'; @@ -130,6 +131,7 @@ function Expensify({ const onSplashHide = useCallback(() => { setIsSplashHidden(true); + Performance.markEnd(CONST.TIMING.SIDEBAR_LOADED); }, []); useLayoutEffect(() => { diff --git a/src/libs/actions/App.ts b/src/libs/actions/App.ts index 302e4048d0e8..f7861631898f 100644 --- a/src/libs/actions/App.ts +++ b/src/libs/actions/App.ts @@ -131,7 +131,6 @@ function setSidebarLoaded() { } Onyx.set(ONYXKEYS.IS_SIDEBAR_LOADED, true); - Performance.markEnd(CONST.TIMING.SIDEBAR_LOADED); Performance.markStart(CONST.TIMING.REPORT_INITIAL_RENDER); } From 71b12acb4fd7c48edd227f3e1fa56659392930c9 Mon Sep 17 00:00:00 2001 From: kirillzyusko Date: Thu, 28 Mar 2024 12:19:42 +0100 Subject: [PATCH 2/2] fix: prettier --- src/Expensify.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Expensify.tsx b/src/Expensify.tsx index 3843c12fdeb5..6a57d6fdcc10 100644 --- a/src/Expensify.tsx +++ b/src/Expensify.tsx @@ -22,11 +22,11 @@ import * as Growl from './libs/Growl'; import Log from './libs/Log'; import migrateOnyx from './libs/migrateOnyx'; import Navigation from './libs/Navigation/Navigation'; -import Performance from './libs/Performance'; import NavigationRoot from './libs/Navigation/NavigationRoot'; import NetworkConnection from './libs/NetworkConnection'; import PushNotification from './libs/Notification/PushNotification'; import './libs/Notification/PushNotification/subscribePushNotification'; +import Performance from './libs/Performance'; import StartupTimer from './libs/StartupTimer'; // This lib needs to be imported, but it has nothing to export since all it contains is an Onyx connection import './libs/UnreadIndicatorUpdater';