Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD #10894] [Bug] Attachment - Small image disappears for a brief moment after tap on send #10029

Closed
kbecciv opened this issue Jul 20, 2022 · 14 comments
Assignees
Labels
Engineering External Added to denote the issue can be worked on by a contributor Weekly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Jul 20, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Launch the app and log in NewDot
  2. Go to chat with any user
  3. On a conversation, click on the + button in the compose box
  4. Click on add attachment and upload an image
    Small image:
    161613034-68f73dac-0734-400d-ba3b-c7068995598f (2)

Expected Result:

Small image does not disappear for a brief moment after tap on send

Actual Result:

Small image disappears for a brief moment after tap on send

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.85.5

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Recording.1197.2.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@melvin-bot
Copy link

melvin-bot bot commented Jul 20, 2022

Triggered auto assignment to @techievivek (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@techievivek
Copy link
Contributor

Will look into it today.

@melvin-bot melvin-bot bot removed the Overdue label Jul 25, 2022
@techievivek
Copy link
Contributor

Once the AddAttachment is refactored, I will re-look into it. From my initial inspection, it looks like for large files, a loading spinner gets rendered, but for very small file sizes it just disappears and reappears.

@techievivek techievivek added Weekly KSv2 and removed Daily KSv2 labels Jul 26, 2022
@techievivek techievivek changed the title Attachment - Small image disappears for a brief moment after tap on send [HOLD API_Refactors]Attachment - Small image disappears for a brief moment after tap on send Aug 2, 2022
@melvin-bot melvin-bot bot added the Overdue label Aug 3, 2022
@techievivek
Copy link
Contributor

Not overdue. Its on hold.

@melvin-bot melvin-bot bot removed the Overdue label Aug 3, 2022
@melvin-bot melvin-bot bot added the Overdue label Aug 15, 2022
@techievivek
Copy link
Contributor

On hold, will look into it when things are sorted.

@melvin-bot melvin-bot bot removed the Overdue label Aug 16, 2022
@melvin-bot melvin-bot bot added the Overdue label Aug 24, 2022
@techievivek
Copy link
Contributor

On hold, will be able to look into it only after the API refactor is completed.

@melvin-bot melvin-bot bot removed the Overdue label Aug 24, 2022
@melvin-bot melvin-bot bot added the Overdue label Sep 2, 2022
@techievivek
Copy link
Contributor

On hold, will have a look after the API refactor is done.

@techievivek
Copy link
Contributor

Going to pass it to external contributors.

@melvin-bot melvin-bot bot removed the Overdue label Sep 12, 2022
@techievivek techievivek changed the title [HOLD API_Refactors]Attachment - Small image disappears for a brief moment after tap on send Attachment - Small image disappears for a brief moment after tap on send Sep 12, 2022
@techievivek techievivek added the External Added to denote the issue can be worked on by a contributor label Sep 12, 2022
@melvin-bot
Copy link

melvin-bot bot commented Sep 12, 2022

Triggered auto assignment to @mallenexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Sep 12, 2022
@techievivek techievivek removed their assignment Sep 12, 2022
@mallenexpensify mallenexpensify changed the title Attachment - Small image disappears for a brief moment after tap on send [HOLD #10894] Attachment - Small image disappears for a brief moment after tap on send Sep 12, 2022
@mallenexpensify mallenexpensify added Weekly KSv2 and removed Daily KSv2 labels Sep 12, 2022
@mallenexpensify
Copy link
Contributor

mallenexpensify commented Sep 12, 2022

Holding cuz of main tracking issue #10894
Want to wait til Rory's back then ping him to see if we should post the job or not

@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@melvin-bot melvin-bot bot added the Overdue label Sep 21, 2022
@mallenexpensify
Copy link
Contributor

@mvtglobally can you see if it's reproducible please?

@melvin-bot melvin-bot bot removed the Overdue label Sep 21, 2022
@JmillsExpensify JmillsExpensify changed the title [HOLD #10894] Attachment - Small image disappears for a brief moment after tap on send [HOLD #10894] [Bug] Attachment - Small image disappears for a brief moment after tap on send Sep 21, 2022
@mvtglobally
Copy link

@mallenexpensify Issue is no longer repro it seems

Recording__2044.mp4

@mallenexpensify
Copy link
Contributor

Gonna close since it's not reproducible, reopen if needed. thanks @mvtglobally !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering External Added to denote the issue can be worked on by a contributor Weekly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants