Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web: Report comment date & time always shows Today, at current time (not when comment was sent) #10042

Closed
Beamanator opened this issue Jul 21, 2022 · 2 comments
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2 Reviewing Has a PR in review

Comments

@Beamanator
Copy link
Contributor

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Log in
  2. Open a chat w/ a history of messages

Expected Result:

Date & Time next to usernames should be accurate

Actual Result:

Date & Time next to usernames show when they were loaded ("Today at ")

Workaround:

New Expensify can still be used, but no workaround for this at the moment

Platform:

Where is this issue occurring?

  • Web ✅
  • iOS (not confirmed)
  • Android ❌
  • Desktop App ❌
  • Mobile Web (not confirmed)

Version Number:
Reproducible in staging?:
Reproducible in production?: ❌ (sometimes)
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: Me & @flodnv
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1658393726910889

View all open jobs on GitHub

@Beamanator Beamanator added DeployBlockerCash This issue or pull request should block deployment Engineering Daily KSv2 labels Jul 21, 2022
@github-actions github-actions bot added Hourly KSv2 and removed Daily KSv2 labels Jul 21, 2022
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@Beamanator Beamanator self-assigned this Jul 21, 2022
@Beamanator
Copy link
Contributor Author

Beamanator commented Jul 21, 2022

Looks like this was caused by: #9560

There's a few places we didn't use lodashGet correctly (example: #9560 (comment))

@Beamanator Beamanator added the Reviewing Has a PR in review label Jul 21, 2022
@melvin-bot melvin-bot bot closed this as completed Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2 Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

2 participants