Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android - Chat - Compose box is moving up when tap on it #10088

Closed
kbecciv opened this issue Jul 25, 2022 · 7 comments
Closed

Android - Chat - Compose box is moving up when tap on it #10088

kbecciv opened this issue Jul 25, 2022 · 7 comments
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Jul 25, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Launch the app
  2. Log in with expensifail account
  3. Select any chat
  4. Tap on compose box

Expected Result:

Compose box is not moving up when tap on it

Actual Result:

Compose box is moving up when tap on it

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Android

Version Number: 1.1.86.0

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Screen_Recording_20220725-172948_New.Expensify.mp4
20220725_173815.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Jul 25, 2022
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Jul 25, 2022

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@marcaaron
Copy link
Contributor

Seems possibly related to the KeyboardAvoidingView stuff. @jasperhuangg ?

@marcaaron
Copy link
Contributor

I am having a hard time testing that theory because reverting this PR comes with conflicts

@luacmartins
Copy link
Contributor

Thanks for the updates @marcaaron. I think @jasperhuangg comes back from ooo tomorrow and will be able to assist us in reverting this?

@luacmartins
Copy link
Contributor

This seems to have been fixed by this revert. Closing.

@marcaaron
Copy link
Contributor

ah nice was just about to do this 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants