[Bug] IOS/Android/Desktop - Messages are showing sent multiple times for sender

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Launch App and login
2. Off WiFi
3. Send some messages to an account you have access too. (Preferably you're logged in on another device with)
4. On WiFi

Expected Result:

Messages sent without internet connection should be sent without any issues.

Actual Result:

Messages are sent twice for sender

Workaround:

Uknown

Platform:

Where is this issue occurring?

• iOS
• Android

Version Number: 1.1.89.0

Reproducible in staging?: Yes

Reproducible in production?: No

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5702689_20220824_113632.mp4

RPReplay_Final1661367712.MP4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @srikarparsi (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[AndrewGable]

Few thoughts:

1. Agree I cannot reproduce on web
2. It seems(??) like a client side only issue since the double message is only seen on iOS and not on web
3. I think you have to leave and re-enter the page for the double message to show

[srikarparsi]

I agree, I wasn't able to reproduce this on web either. In the second video though, it looks like the message is rendering twice in the app without the user leaving the page.

[srikarparsi]

I'm un-assigning myself as I don't have much knowledge yet in ios/android and don't think I will be able to figure it out quick enough but will take a look back at the issue in the morning.

[AndrewGable]

OK we've decided to unblock this and move on. It requires a large-ish fix that is "moving backwards" in terms of where we want to go in terms of optimistic report action IDs/sequenceNumbers, so we are going to live with the bug for a little bit, then make sure it's fixed once we have removed sequenceNumbers.

[AndrewGable]

@Expensify/applauseleads - Can you re-test?

[kavimuru]

@AndrewGable Able to reproduce in Android (1.1.97-2). iOS build is still 96.5 and able to reproduce.

https://user-images.githubusercontent.com/43996225/188719348-8a3137e1-6b6d-40ed-9e05-f0ac58e620b2.mp4
https://user-images.githubusercontent.com/43996225/188719896-d19a94c6-9e99-4fe1-9078-82fd5b539671.MP4

[AndrewGable]

Ok thank you - I believe the fix is still in the works.

[mallenexpensify]

This appears to also be happening on desktop and it's semi-consistent. Thread, examples and logs here
https://expensify.slack.com/archives/C01GTK53T8Q/p1663717163964739?thread_ts=1663714013.290919&cid=C01GTK53T8Q

@JmillsExpensify I think you should add this to WA Project. I'll keep digging for more examples (inc. web) and reproducible steps

[JmillsExpensify]

Yes, agreed. I'll add it as this keeps coming up.

[mallenexpensify]

New bits from testing - Slack post

Here's an interesting tidbit...

1. Noticed I had multiple of the same message show from me to Scott on Desktop Version 1.2.5-0
2. Scrolled up to see how many were showing and to get screenshot
3. Noticed as I scrolled (both ways?) that new duplicates were loading

Seems like it's related to loading or maybe pagination? (guessing). Vid and logs.
scroll to make duplicate message.txt

2022-09-22_11-49-55.mp4

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[trjExpensify]

I'm going to update the title of this issue to put [Hold Sequence #] in it as I understand we're held here on implementing that project.

[JmillsExpensify]

I'm kind of on the fence. I would almost rather track this issues elsewhere than keep them open in the repo. The focus here should be on bugs and performance improvements we can and are actively fixing. So I think I'd rather just not it somewhere, close it, and test it later.

[mallenexpensify]

Can't we just use the [HOLD] title preface and Planning label?
What's he problem we're trying to solve by closing known bugs that aren't fixed?

[JmillsExpensify]

I'm not super passionate. Feel free to keep for now. We can circle back when API Unchained is done and bugs/performance and the like are our top priority for WAQ.

[mvtglobally]

Issue not reproducible during KI retests. (Second week)

[AndrewGable]

Still on hold.

[JmillsExpensify]

Added myself so that I can keep track of this one during the sequence numbers implementation.

[JmillsExpensify]

Still holding until we get sequence numbers out.

[JmillsExpensify]

Still waiting on sequence numbers.

[mvtglobally]

Issue not reproducible during KI retests. (Third week)

[mvtglobally]

@JmillsExpensify @AndrewGable
We noticed slightly different behavior in staging today. Could it be related to the same issue reported here?
#12886 (comment)

[JmillsExpensify]

Yes, same issue. Commented in the linked PR.

[JmillsExpensify]

Still held on sequence numbers.

[JmillsExpensify]

Still on hold for SN, though hopefully we'll be through that and ready and test in the coming week or two.

[JmillsExpensify]

Held on sequence numbers.

[JmillsExpensify]

Still on hold for SN.

[JmillsExpensify]

Taking this off hold and trying to reproduce now.

[JmillsExpensify]

Unable to reproduce now, and this is actually similar to another recently closed issue #10615. Closing and adding the needs reproduction label.